-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_all_channels() for setting on, off counter values and full-on and full-off in one transaction #18
Conversation
f06b7d5
to
f289201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Could you also add an entry to the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could you also briefly explain this function in the readme/lib.rs like the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run cargo fmt
again?
76f0695
to
29d017f
Compare
Done. Sorry for not checking this. I ran |
I have published this in version 1.0. Thanks! |
Follow-up and alternative solution to PR #17. See discussion over there for detailed description of the problem and advantages and disadvantages of the solution approach.